Skip to content

Conversation

@Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Aug 12, 2025

Relands #152295.

Checking for the overloads did not account for them being out of order. For example, the failed output contained the overloads, but out of order. The last commit here fixes that by using -DAG.

@Nerixyz Nerixyz requested a review from JDevlieghere as a code owner August 12, 2025 10:14
@JDevlieghere JDevlieghere merged commit 44f41f5 into llvm:main Aug 12, 2025
10 checks passed
@slydiman
Copy link
Contributor

The following shell tests are broken on lldb-x86_64-win after this patch

lldb-shell::process_load.cpp
lldb-shell::msstl_smoke.cpp

Please take a look and fix them ASAP.

Michael137 pushed a commit that referenced this pull request Aug 14, 2025
Some functions don't have the `FunctionType` set. We can't look these up
and won't be able to call them, so ignore them when caching the function
names.

This does fix the failures caused by
#153160 mentioned in
#153160 (comment).
However, in `lldb-shell::msstl_smoke.cpp` there's another failure not
introduced by #153160 (fixed with #153386).
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Aug 14, 2025
…okup (#153382)

Some functions don't have the `FunctionType` set. We can't look these up
and won't be able to call them, so ignore them when caching the function
names.

This does fix the failures caused by
llvm/llvm-project#153160 mentioned in
llvm/llvm-project#153160 (comment).
However, in `lldb-shell::msstl_smoke.cpp` there's another failure not
introduced by #153160 (fixed with #153386).
ZequanWu added a commit that referenced this pull request Sep 2, 2025
…stically. (#156530)

#153160 created those function
maps and uses default sort comparator which is not deterministic when
there are multiple entries with same name because llvm::sort is unstable
sort.

This fixes it by comparing the id value when tie happens and sort
`m_type_base_names` deterministically as well.
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Sep 2, 2025
…s deterministically. (#156530)

llvm/llvm-project#153160 created those function
maps and uses default sort comparator which is not deterministic when
there are multiple entries with same name because llvm::sort is unstable
sort.

This fixes it by comparing the id value when tie happens and sort
`m_type_base_names` deterministically as well.
@Nerixyz Nerixyz deleted the feat/lldb-npdb-function-lookup branch November 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants